Fix for AttributeError in id_regex match.group()

umbra/tests/test_controller.py

@@ -45,18 +45,18 @@ class ControllerTest(pyfakefs.fake_filesystem_unittest.TestCase):
         self.assertEqual(controller._source_files, [])
         self.assertEqual(controller._shadow_files, [])
 
-    # def test_compare_files_view(self):
-    #     model, view, controller = self.makeMVC()
-    #     controller._source_files = ["foo"]
-    #     controller._compare_files()
-    #     view.update_message.assert_called_with("no shadow")
-    #     controller._shadow_files = ["bar"]
-    #     controller._compare_files()
-    #     calls = [mock.call("no shadow"), mock.call("files ok"), mock.call("comparison complete")]
-    #     view.update_message.assert_has_calls(calls)
-    #     calls_but = [mock.call("save", "normal"), mock.call("compare", "disabled")]
-    #     view.button_status.assert_has_calls(calls_but)
-    #
+    def test_compare_files_view(self):
+        model, view, controller = self.makeMVC()
+        controller._source_files = ["foo"]
+        controller._compare_files()
+        view.update_message.assert_called_with("no shadow")
+        controller._shadow_files = ["bar"]
+        controller._compare_files()
+        calls = [mock.call("no shadow"), mock.call("files ok"), mock.call("comparison complete")]
+        view.update_message.assert_has_calls(calls)
+        calls_but = [mock.call("save", "normal"), mock.call("compare", "disabled")]
+        view.button_status.assert_has_calls(calls_but)
+
     # def test_read_folder_source(self):
     #     model, view, controller = self.makeMVC()
     #     model.get_multi_data.return_value = {}

umbra/utils.py

@@ -85,7 +85,10 @@ class Utils:
             the found id for the file
         """
         match = re.search(r"\d+\.T", path)
-        identifier = match.group()
+        if match:
+            identifier = match.group()
+        else:
+            identifier = ""  # match is None when no such path found
         return identifier[:-2]
 
     @staticmethod