Sc209/dropdown menus

• Made a class of the review window in the View
• The drop down menu in the review window has now all ShadowTasks (aka trials) which you can view. Really nice. No functionality yet.
• Fixed some things that were ugly. For example, I added underscores to some variable names. Maybe some argue that all the underscores are ugly, but it makes the file way more readable and now the IDE does not complain any more about spelling mistakes.

umbra/controller.py

@@ -14,8 +14,8 @@ class Controller:
         self._view.action_listener = self.action_listener
 
         # File reading and writing supported for .csv only
-        self._filereader = CSVReader()
-        self._filewriter = CSVWriter()
+        self._file_reader = CSVReader()
+        self._file_writer = CSVWriter()
 
         # Lists of paths, represented as string
         self._source_files = []
@@ -57,7 +57,7 @@ class Controller:
         elif action == 'save':
             self._save_results()
         elif action == 'save_csv':
-            self._filewriter = CSVWriter()
+            self._file_writer = CSVWriter()
         elif action == 'select_folder':
             self._select_folder(type_code[0])
         elif action == 'rm_all':
@@ -172,12 +172,12 @@ class Controller:
                 mistake_title = self._compose_csv_title('mistakes')
                 delay_title = self._compose_csv_title('delay')
                 self._view.update_message('saved')
-                self._filewriter.write_frame(path,
-                                             mistake_results,
-                                             mistake_title)
-                self._filewriter.write_frame(path,
-                                             delay_results,
-                                             delay_title)
+                self._file_writer.write_frame(path,
+                                              mistake_results,
+                                              mistake_title)
+                self._file_writer.write_frame(path,
+                                              delay_results,
+                                              delay_title)
                 self._view.update_message('saved')
             except PermissionError:
                 self._view.update_message('no_dir')
@@ -199,13 +199,13 @@ class Controller:
                 success = False
             else:
                 success = True
-            source_data = self._filereader.read(file_path, 'source')
+            source_data = self._file_reader.read(file_path, 'source')
             shadows = np.array([])
             source_success.append(success)
             for shadow_candidate in non_matched_shadows:
                 participant, condition = shadow_regex(shadow_candidate, video)
                 if condition is not None:
-                    shadow_data = self._filereader.read(shadow_candidate,
+                    shadow_data = self._file_reader.read(shadow_candidate,
                                                         'shadow')
                     self._model.add_task(participant,
                                          video,